-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve consistency of the Post editor and Site editor Document actions #52246
Conversation
The code changes in this PR are simple enough. I'd appreciate some eyes on the CSS changes part. Cc @jasmussen |
Size Change: -28 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f3480eb
to
65fd4b2
Compare
65fd4b2
to
2b67b2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! Code LGTM.
I'm guessing the labelling issue will be addressed in a separate PR? It's a complicated one as long as the button is also acting as a page title.
I think we should add this to 6.3 given the document actions button is a new feature for this release, and this fixes a most annoying bug. |
|
Yes the fact the button is also acting as a page title is not ideal and it's a problem that will likely need some discussion to be solved. I'd suggest to keep #51460 and #51729 open. Thank you for the review! |
…ns (#52246) * Remove redundant shortcut button. * Fix focus and hover style and improve consistency. * Rename post document-title and improve CSS consistency.
I just cherry-picked this PR to the update/packages-wp-6-3-RC3 branch to get it included in the next release: a44342f |
* Patterns: Enable focus mode editing (#52427) * PreventDefault when isComposing is true. apply patch from t-hamano. (#52844) see: #52821 (comment) * List View: Ensure onDrop does not fire if there is no target (#52959) * I18N: Add missing Gettext wrapper on strings in Edit Post overview sidebar (#52971) * I18N: Add missing gettext wrapper * Add context to disambiguate 'Outline' that is commonly used on borders. * Footnotes: disable based on post type (#52934) * Footnotes: disable based on post type * Address feedback * Fix typo * Format: disable if block is not registered * Lock usesContext api * Use Symbol instead of Math.random * Patterns Browse Screen: Fix back button when switching between categories (#52964) * Patterns: Allow orphaned template parts to appear in general category (#52961) * Spacing presets: fix bug with select control adding undefined preset values (#53005) * Site Editor: Fix canvas mode sync with URL (#52996) * Check if spacing tool is defined before displaying controls. (#53008) * Check if spacing tool is defined before displaying controls. * Don't show sides if spacing type false * Improve consistency of the Post editor and Site editor Document actions (#52246) * Remove redundant shortcut button. * Fix focus and hover style and improve consistency. * Rename post document-title and improve CSS consistency. * Site Editor: Fix the typo in the title label map (#53071) * Fix patterns search crash: check for existence of defaultView before attempting to get styles (#52956) * backport paging bug fixes (#53091) --------- Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: Hiroshi Urabe <[email protected]> Co-authored-by: Andrew Serong <[email protected]> Co-authored-by: Pedro Mendonça <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Aaron Robertshaw <[email protected]> Co-authored-by: Glen Davies <[email protected]> Co-authored-by: tellthemachines <[email protected]> Co-authored-by: Andrea Fercia <[email protected]>
This PR seeks to address part of #51460 and #51729
What?
The 'document title' / 'document actions' in the top bar are inconsistent between the Post editor and the Site editor, especially in 'editing template' mode.
Why?
How?
DocumentTitle
component toDocumentActions
for consistency. Also, this component is not just the 'title'. It does more than that so the nameDocumentActions
seems more appropriate.About the CSS changes
Worth noting that on trunk the DocumentTitle / DocumentActions already have some layout issues, especially on small screens.
On desktop, long text overflow behaves differently. Screenshot of Post editor vs. Site editor:
The text overflow should work way better with this PR.
This PR does not aim to fix the layout breakage on small screens, especially in the Post editor. This should be addressed separately. Screenshot from trunk:
With long text:
Post editor, shorter text on even smaller screen:
Testing Instructions
⌘K
is not a separate button any longer.The quick, brown fox jumps over a lazy dog. DJs flock by when MTV ax quiz prog
As said above, on small screens the layout isn't great and breaks. It already happens on trunk and should be addressed separately. Not in the scope of this PR.
Testing Instructions for Keyboard
Screenshots or screencast